Skip to content

AbstractJackson2Decoder#decodeToMono support non-blocking parsing #34586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

AbstractJackson2Decoder#decodeToMono support non-blocking parsing #34586

wants to merge 2 commits into from

Conversation

ShenFeng312
Copy link
Contributor

@ShenFeng312 ShenFeng312 commented Mar 13, 2025 •
edited
Loading

see #25838

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 13, 2025
@bclozel
Copy link
Member

bclozel commented Mar 13, 2025

Have you tried building locally before submitting a PR? This doesn't pass the build.

@bclozel bclozel added the status: waiting-for-feedback We need additional information before we can continue label Mar 13, 2025
@ShenFeng312
Copy link
Contributor Author

@bclozel I'm sorry, I only ran JSON-related test cases locally and overlooked the implementation of Jackson2CborDecoder I will fix it and perform a complete local build.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Mar 13, 2025
@ShenFeng312
Copy link
Contributor Author

Can you help me review the code or give me some suggestions?@bclozel

@bclozel
Copy link
Member

bclozel commented Mar 14, 2025

I don't think we should consider this implementation before fully understanding the performance tradeoffs as discussed in #25838 (comment). This change could very well decrease throughput significantly for small JSON responses (which is probably the main case when deserializing a single object).

Thanks for your contribution, but we need to first get to the bottom of the performance tradeoffs before considering a concrete implementation.

@bclozel bclozel closed this Mar 14, 2025
@bclozel bclozel added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on status: feedback-provided Feedback has been provided labels Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShenFeng312 @bclozel @spring-projects-issues