Add support for java.util.Optional to GenericHttpMessageConverter #24498 #26393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
encircled
changed the title
sbrannen
added
in: web
spring-web/src/main/java/org/springframework/http/converter/AbstractHttpMessageConverter.java
Show resolved
Hide resolved
encircled
force-pushed
the
24498-fix-optional-unboxing
branch
from
462300c to
72984e5
Compare
|
@sbrannen just a kind reminder. Lets review&merge or close it if you think that such behaviour should not be part of the product |
|
Any update for this PR? |
encircled
force-pushed
the
24498-fix-optional-unboxing
branch
from
72984e5 to
3ab30a2
Compare
|
Thank for for submitting a PR, and our apologies for taking this long to resolve it. We have decided to resolve the underlying issue differently than suggested in this PR, in the Jackson converters rather than the generic converters. See 5502e61 for more details. |
|
sbrannen
added
status: superseded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24498
Added unboxing of
java.util.OptionaltoAbstractHttpMessageConverterandAbstractGenericHttpMessageConverter. If the object is not unboxed, the underlying message converter receives an instance ofjava.util.Optional, which was causing an issue described in the #24498 in case of Jackson converter. It will also allow to useOptional<*>in other message converters without explicitly registering a type converter.