Fix writing collections where first element is null#2218
Closed
tamland wants to merge 1 commit into
Closed
Conversation
3daa844 to
3f735de
Compare
Author
Contributor
|
When rebased against current main the test you added does not work with Postgres. Also To run all tests using Postgres as the database run To run all tests with all databases run Let us know if you want to keep working on this PR, or if we should close it. |
ad02587 to
db5c5b2
Compare
Author
|
@schauder Thanks, I was just running the default test config which clearly didn't do anything. I have updated the PR to at least fix the issue for simple array types. However, I am unable find a good solution for |
Closes spring-projects#2215 Signed-off-by: Thomas Amland <thomas.amland@gmail.com>
db5c5b2 to
7a7c0f3
Compare
Contributor
|
That is unfortunate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #2215. It is unclear to me what the code checking the class of the first element is supposed to solve as there appear to be no tests covering its behavior.