Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClassCastException for CassandraObservationContext #1541

Closed
wants to merge 1 commit into from
Closed

Fix ClassCastException for CassandraObservationContext #1541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions ...main/java/org/springframework/data/cassandra/observability/ObservationRequestTracker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
package org.springframework.data.cassandra.observability;

import io.micrometer.observation.Observation;
import io.micrometer.observation.Observation.Context;
import io.micrometer.observation.Observation.Event;

import org.apache.commons.logging.Log;
Expand Down Expand Up @@ -85,15 +86,19 @@ public void onNodeError(Request request, Throwable error, long latencyNanos, Dri
if (request instanceof CassandraObservationSupplier) {

Observation observation = ((CassandraObservationSupplier) request).getObservation();
Context context = observation.getContext();

((CassandraObservationContext) observation.getContext()).setNode(node);
if (context instanceof CassandraObservationContext) {

observation.highCardinalityKeyValue(
String.format(HighCardinalityKeyNames.NODE_ERROR_TAG.asString(), node.getEndPoint()), error.toString());
observation.event(Event.of(Events.NODE_ERROR.getValue()));
((CassandraObservationContext) context).setNode(node);

if (log.isDebugEnabled()) {
log.debug("Marking node error for [" + observation + "]");
observation.highCardinalityKeyValue(
String.format(HighCardinalityKeyNames.NODE_ERROR_TAG.asString(), node.getEndPoint()), error.toString());
observation.event(Event.of(Events.NODE_ERROR.getValue()));

if (log.isDebugEnabled()) {
log.debug("Marking node error for [" + observation + "]");
}
}
}
}
Expand All @@ -105,13 +110,17 @@ public void onNodeSuccess(Request request, long latencyNanos, DriverExecutionPro
if (request instanceof CassandraObservationSupplier) {

Observation observation = ((CassandraObservationSupplier) request).getObservation();
Context context = observation.getContext();

((CassandraObservationContext) observation.getContext()).setNode(node);
if (context instanceof CassandraObservationContext) {

observation.event(Event.of(Events.NODE_SUCCESS.getValue()));
((CassandraObservationContext) context).setNode(node);

if (log.isDebugEnabled()) {
log.debug("Marking node success for [" + observation + "]");
observation.event(Event.of(Events.NODE_SUCCESS.getValue()));

if (log.isDebugEnabled()) {
log.debug("Marking node success for [" + observation + "]");
}
}
}
}
Expand Down