Skip to content

Support @MeterTag on @Counted and @Timed methods #46007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Support @MeterTag on @Counted and @Timed methods #46007

wants to merge 7 commits into from
+159 −32

Conversation

doumdoum
Copy link
Contributor

@doumdoum doumdoum commented Jun 18, 2025 •
edited
Loading

Aligns the @Counted annotation with the @Timed annotation to support dynamic tags.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 18, 2025
@wilkinsona
Copy link
Member

Thanks for the proposal.

I think it would be better to support @MeterTag in a manner that's similar to the existing support for @SpanTag. Would you like to update this PR along those lines? Specifically, we could automatically create the MeterTagAnnotationHandler that uses the bean factory to retrieve the ValueResolver and provides a SpEL-based expression resolver.

@wilkinsona wilkinsona added status: waiting-for-feedback We need additional information before we can continue labels Jun 18, 2025
@doumdoum doumdoum force-pushed the add-meter-tag-to-counter branch 2 times, most recently from 697241a to 70f356e Compare June 20, 2025 16:57
@doumdoum doumdoum changed the title support dynamic tags in @Counted annotation support dynamic tags in @Counted and @Timed annotations Jun 23, 2025
@doumdoum
Copy link
Contributor Author

@wilkinsona i addressed your comments.
Thx for your review.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jun 23, 2025
wilkinsona
wilkinsona requested changes Jun 25, 2025
View reviewed changes
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @doumdoum. I've left a few comments for your consideration. The build is also failing at the moment. Please build your changes locally and make sure that the build is successful.

@wilkinsona wilkinsona added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Jun 25, 2025
@doumdoum doumdoum force-pushed the add-meter-tag-to-counter branch from ef646ef to ab32879 Compare June 25, 2025 21:52
@doumdoum doumdoum requested a review from wilkinsona June 26, 2025 07:10
wilkinsona
wilkinsona requested changes Jun 26, 2025
View reviewed changes
doumdoum added 7 commits June 26, 2025 13:08
@doumdoum
add meterTags to counted aspects.
127b3a0 
Signed-off-by: Dominique Villard <[email protected]>
@doumdoum
Make SpelTagValueExpressionResolver available for metrics and rework …
c0e97fe 
…it so that it parses expressions only once

Signed-off-by: Dominique Villard <[email protected]>
@doumdoum
Fix analysis issues
8ed5e09 
Signed-off-by: Dominique Villard <[email protected]>
@doumdoum
Use SpelTagValueExpressionResolver to provision meter tags
1d0f59e 
Signed-off-by: Dominique Villard <[email protected]>
@doumdoum
Move SpelTagValueExpressionResolver to metrics package. Fix checkstyle.
bf986d1 
Signed-off-by: Dominique Villard <[email protected]>
@doumdoum
Rename variable
0838b57 
Signed-off-by: Dominique Villard <[email protected]>
@doumdoum
Revert SpelTagValueExpressionResolver code
5ba8b83 
Signed-off-by: Dominique Villard <[email protected]>
@doumdoum doumdoum force-pushed the add-meter-tag-to-counter branch from bf5aa73 to 5ba8b83 Compare June 26, 2025 11:09
@doumdoum doumdoum requested a review from wilkinsona June 26, 2025 11:09
@jonatan-ivanov jonatan-ivanov mentioned this pull request Jun 26, 2025
Open
@wilkinsona wilkinsona removed the status: waiting-for-feedback We need additional information before we can continue label Jun 28, 2025
@doumdoum
Copy link
Contributor Author

doumdoum commented Jul 1, 2025 •
edited
Loading

@wilkinsona should i do the conflicts resolution ?

@wilkinsona
Copy link
Member

Thanks for the offer, @doumdoum, but please don't worry about it. We can take care of the conflicts as part of merging the contribution.

@wilkinsona wilkinsona self-assigned this Jul 2, 2025
@wilkinsona wilkinsona changed the title support dynamic tags in @Counted and @Timed annotations Support @MeterTag on @Counted and @Timed methods Jul 2, 2025
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 2, 2025
@wilkinsona wilkinsona modified the milestones: 4.0.x, 4.0.0-M1 Jul 2, 2025
wilkinsona pushed a commit that referenced this pull request Jul 2, 2025
@doumdoum @wilkinsona
Add @MeterTag support to existing @timed and @counted support
8b04ace 
Signed-off-by: Dominique Villard <[email protected]>

See gh-46007
wilkinsona added a commit that referenced this pull request Jul 2, 2025
@wilkinsona
Polish "Add @MeterTag support to existing @timed and @counted support"
88f4af7 
See gh-46007
@wilkinsona wilkinsona closed this in d251321 Jul 2, 2025
@wilkinsona
Copy link
Member

Thanks very much, @doumdoum, and congratulations on making your first contribution to Spring Boot.

@doumdoum
Copy link
Contributor Author

doumdoum commented Jul 2, 2025

Thx for your great hard work !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkinsona wilkinsona Awaiting requested review from wilkinsona

Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
4.0.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@doumdoum @wilkinsona @spring-projects-issues