Dependency management for JUnit 5 is incomplete #12635
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clemstoquart Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@clemstoquart Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: bug
|
Thanks for the PR, @clemstoquart. When merging this, we should check that we haven't missed any of JUnit Jupiter's other modules. |
wilkinsona
changed the title
wilkinsona
changed the title
|
For the record, |
|
I'd forgotten that. I can't recall if I agreed with the reasoning then, but I don't agree with it now. The module being experimental shouldn't cause us to make it harder than it needs to be to use the right version of it. |
philwebb
added a commit
that referenced
this pull request
Apr 5, 2018
* pr/12635: Add missing managed JUnit Jupiter dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR add two new managed dependencies for Junit 5 :
junit-jupiter-params: which is one of the major Junit 5 featurejunit-vintage-engine: which allow a painless migration from Junit 4.x to Junit 5Have a nice day.