Polish argument capturing in two Tomcat tests #12203
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
snicoll
approved these changes
Feb 24, 2018
snicoll
added a commit
that referenced
this pull request
Feb 26, 2018
* pr/12203: Polish argument capturing in two Tomcat tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in this PR I initially wanted to replace
InvocationOnMock.getArguments()[0]with the cleanerInvocationOnMock.getArgument(0)that could get rid of some casting. While typing I realized that we could clean things further up and useArgumentCaptorinstead of writing anAnswerthat does an additional assertion, which I find somewhat questionable.Let me know what you think.
Cheers,
Christoph