Skip to content

Add actuator support for RSocket #16282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bclozel opened this issue Mar 21, 2019 · 12 comments
Closed

Add actuator support for RSocket #16282

bclozel opened this issue Mar 21, 2019 · 12 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement

Comments

@bclozel
Copy link
Member

bclozel commented Mar 21, 2019

Since #16021, Spring Boot supports RSocket as a type of server applications (meaning there's a single RSocket server available and no HTTP server).

We should try and expose actuator endpoints in a meaningful way over RSocket.

@bclozel bclozel added the type: enhancement A general enhancement label Mar 21, 2019
@bclozel bclozel added this to the 2.2.x milestone Mar 21, 2019
@bclozel bclozel self-assigned this Mar 21, 2019
@spencergibb
Copy link
Member

I'm very interested in this as well. It will be interesting to see how this gets done as the routing in Framework is still basic (simple string). Spring Cloud Gateway needs similar functionality.

@philwebb
Copy link
Member

I think we might run out of time for this one. I'm going to move it to 2.x for now (@bclozel feel free to move back if you have something in hand already).

@philwebb philwebb modified the milestones: 2.2.x, 2.x May 24, 2019
@spencergibb
Copy link
Member

@bclozel I'd like to chat with you about it. Gateway needs something like this and I'd like to be not far off when I implement it there.

@onobc
Copy link
Contributor

onobc commented Oct 31, 2019

@bclozel I would love to help out on this one.

@philwebb philwebb modified the milestones: 2.x, 2.3.x Nov 7, 2019
@bclozel bclozel modified the milestones: 2.3.x, 2.x Nov 14, 2019
@bclozel
Copy link
Member Author

bclozel commented Nov 14, 2019

@snicoll and I are looking into this issue. We've discussed with the Framework team about this and it seems that:

  • there are a lot of open questions still about conventions and best practices when it comes to routes and RSocket interaction models
  • we're missing critical infrastructure in Spring Framework to support this, and this might be considered at the same time as a possible functional programming model as well.
  • we need to learn more about the use cases behind this and what other pieces would be missing to provide a complete support (we'll get in touch with @spencergibb for that)

We're pushing it back to 2.x as 2.3 will be based on Spring Framework 5.2 and we won't have time to cover all this in the next release.

@snicoll snicoll removed their assignment Feb 3, 2020
@AxelHeathnet
Copy link

Is this still open?

@bclozel bclozel added the status: pending-design-work Needs design work before any code can be developed label May 3, 2020
@bclozel
Copy link
Member Author

bclozel commented May 3, 2020

@AxelHeathnet yes

@hexasm
Copy link

hexasm commented Nov 13, 2020

Any progress ?

@bclozel
Copy link
Member Author

bclozel commented Nov 13, 2020

@peter-natkaniec not yet - we suspect we'll need more infrastructure from Spring Framework itself, but we need to work on drafting this support first. We're looking at the number of votes on issues to prioritize work.

@tomasz-galuszka
Copy link

tomasz-galuszka commented Dec 1, 2020

Looks like a big blocker for going into production without monitoring (I mean prometheus/grafana stack). Are there any other ways for monitoring r-socket based micro-services ?

Maybe https://github.com/micrometer-metrics/prometheus-rsocket-proxy ?

@PPrydorozhnyi
Copy link

any news please?

@bclozel bclozel removed their assignment Mar 10, 2023
@bclozel
Copy link
Member Author

bclozel commented Jun 19, 2024

We haven't made much progress on this and the demand is quite low compared to many other feature requests. I'm closing this issue for now. We can reconsider this decision depending on the number of votes on this issue.

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2024
@bclozel bclozel removed the status: pending-design-work Needs design work before any code can be developed label Jun 19, 2024
@bclozel bclozel added the status: declined A suggestion or change that we don't feel we should currently apply label Jun 19, 2024
@bclozel bclozel removed this from the 3.x milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

9 participants