-
Notifications
You must be signed in to change notification settings - Fork 38.5k
Instrument RSocket Requester for Observability #32372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think this is a duplicate of spring-projects/spring-boot#16282. |
I'm not sure this is a duplicate. AIUI, spring-projects/spring-boot#16282 is about making the Actuator's endpoints available over RSocket and this issue is about RSocket-related metrics. |
Hi @mbhave, what @wilkinsona said is right. This issue is about enabling RSocketRequester metric and auto-configuration, and not about making actuator available over RSocket. Currently RSocketRequester doesn't send any metrics (count and latency) CMIIW, and also there's no clean way to add metrics (no customizer). Maybe just ignore the "actuator" part of this issue to remove confusion. |
Thanks for the clarification @riko-traveloka. I have reopened the issue. |
any progress? |
@zggg no progress so far as the demand is quite low. We will need to instrument the RSocket Requester directly in Spring Framework first before considering any auto-configuration in Spring Boot (this is why the issue has been transferred). |
Hi team, until Spring Boot 2.4.0, there's no metrics auto-configuration for RSocketRequester. Would be nice if there's metrics auto-configuration so that we have visibility over the interaction (request-response, fire-forget, etc), both count and latency.
The text was updated successfully, but these errors were encountered: