Skip to content

Instrument RSocket Requester for Observability #32372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riko-traveloka opened this issue Dec 8, 2020 · 6 comments
Open

Instrument RSocket Requester for Observability #32372

riko-traveloka opened this issue Dec 8, 2020 · 6 comments
Labels
theme: observability An issue related to observability and tracing type: enhancement A general enhancement

Comments

@riko-traveloka
Copy link

Hi team, until Spring Boot 2.4.0, there's no metrics auto-configuration for RSocketRequester. Would be nice if there's metrics auto-configuration so that we have visibility over the interaction (request-response, fire-forget, etc), both count and latency.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 8, 2020
@mbhave
Copy link
Contributor

mbhave commented Dec 8, 2020

I think this is a duplicate of spring-projects/spring-boot#16282.

@mbhave mbhave closed this as completed Dec 8, 2020
@mbhave mbhave added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 8, 2020
@wilkinsona
Copy link
Member

I'm not sure this is a duplicate. AIUI, spring-projects/spring-boot#16282 is about making the Actuator's endpoints available over RSocket and this issue is about RSocket-related metrics.

@riko-traveloka
Copy link
Author

Hi @mbhave, what @wilkinsona said is right. This issue is about enabling RSocketRequester metric and auto-configuration, and not about making actuator available over RSocket.

Currently RSocketRequester doesn't send any metrics (count and latency) CMIIW, and also there's no clean way to add metrics (no customizer).

Maybe just ignore the "actuator" part of this issue to remove confusion.

@mbhave
Copy link
Contributor

mbhave commented Dec 12, 2020

Thanks for the clarification @riko-traveloka. I have reopened the issue.

@mbhave mbhave reopened this Dec 12, 2020
@mbhave mbhave removed the status: duplicate A duplicate of another issue label Dec 12, 2020
@wilkinsona wilkinsona added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 12, 2020
@bclozel bclozel added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 6, 2021
@zggg
Copy link

zggg commented Mar 5, 2024

any progress?

@bclozel bclozel transferred this issue from spring-projects/spring-boot Mar 5, 2024
@bclozel bclozel changed the title Request RSocket Metrics Actuator Autoconfiguration Instrument RSocket Requester for Observability Mar 5, 2024
@bclozel bclozel added the theme: observability An issue related to observability and tracing label Mar 5, 2024
@bclozel bclozel added this to the General Backlog milestone Mar 5, 2024
@bclozel
Copy link
Member

bclozel commented Mar 5, 2024

@zggg no progress so far as the demand is quite low. We will need to instrument the RSocket Requester directly in Spring Framework first before considering any auto-configuration in Spring Boot (this is why the issue has been transferred).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: observability An issue related to observability and tracing type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

6 participants