Skip to content

Conversation

@alxkm
Copy link
Contributor

@alxkm alxkm commented Oct 29, 2025

Description

This PR adds additional test coverage for the JsonSchemaConverter class to ensure proper handling of various JSON Schema properties during conversion to OpenAPI format.

Changes

  • Added 3 new test cases to JsonSchemaConverterTests covering critical property conversion scenarios
  • Tests ensure proper conversion of boolean values, enums, and OpenAPI-specific properties

Test Coverage

The new tests cover:

  • Boolean additionalProperties handling (testing with true value)
  • Enum property preservation with string array values
  • OpenAPI-specific properties:
    • nullable boolean property
    • readOnly boolean property
    • writeOnly boolean property
    • Complex description object structure

Testing

All tests pass successfully and verify that the JsonSchemaConverter correctly:

  • Preserves boolean property values
  • Maintains enum arrays during conversion
  • Properly handles OpenAPI-specific properties that may not exist in standard JSON Schema

alxkm added 2 commits October 29, 2025 18:11
Co-authored-by: Oleksandr Klymenko <[email protected]>
Signed-off-by: Oleksandr Klymenko <[email protected]>
Co-authored-by: Oleksandr Klymenko <[email protected]>
Signed-off-by: Oleksandr Klymenko <[email protected]>
@ilayaperumalg ilayaperumalg added this to the 1.1.0.M4 milestone Oct 30, 2025
@ilayaperumalg ilayaperumalg self-assigned this Oct 30, 2025
@ilayaperumalg
Copy link
Member

@alxkm Thanks for the PR improving the test coverage.

@ilayaperumalg
Copy link
Member

Rebased and merged as 6593762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants