Skip to content

Also mention the net.devh:grpc-spring-boot-starter library #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Also mention the net.devh:grpc-spring-boot-starter library #1213

merged 2 commits into from
Feb 19, 2019

Conversation

ST-DDT
Copy link
Contributor

@ST-DDT ST-DDT commented Feb 16, 2019

Currently you mention only one library for grpc spring-boot support, but there are currently two main libraries.

LogNet/grpc-spring-boot-starter only supports the server side, whereas yidongnan/grpc-spring-boot-starter supports the server and client side, as well as Spring-Security and other features.

Please also mention the second library.

Disclosure: I'm one of the core maintainers of yidongnan/grpc-spring-boot-starter.

@pivotal-issuemaster
Copy link

@ST-DDT Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@ST-DDT Thank you for signing the Contributor License Agreement!

@spencergibb
Copy link
Member

Which does sleuth integrate with in this repository?

@ST-DDT
Copy link
Contributor Author

ST-DDT commented Feb 16, 2019

This library contains support classes for the lognet library. See TraceGrpcAutoConfiguration
and some other support classes that are needed because they are not present in that library.

yidongnan/grpc-spring-boot-starter supports this library out of the box: See TraceClientAutoConfiguration . No further support classes are needed. If you want, we could move the sleuth related client + server configuration here as well.

@ST-DDT
Copy link
Contributor Author

ST-DDT commented Feb 16, 2019

@spencergibb
Copy link
Member

We don't really document external projects. We may link to it, but not document it

@ST-DDT
Copy link
Contributor Author

ST-DDT commented Feb 17, 2019

Changed the PR to only contain the link.

PS: Why is the build failing? I only changed the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants