Add defensive warning for multiple Feign Client beans to avoid potential resource exhaustion#1333
Open
98001yash wants to merge 1 commit intospring-cloud:mainfrom
Open
Add defensive warning for multiple Feign Client beans to avoid potential resource exhaustion#133398001yash wants to merge 1 commit intospring-cloud:mainfrom
98001yash wants to merge 1 commit intospring-cloud:mainfrom
Conversation
…ntial resource exhaustion Signed-off-by: 98001yash <yashchauhan.gaya@gmail.com>
227d0c3 to
a5303ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a defensive warning in
FeignClientFactoryBean#getTarget()to detect multiple
Clientbeans defined within a Feign client context.Although Feign clients are typically configured with singleton-scoped
Clientbeans, misconfiguration (such as defining multiple or non-singletonClientbeans) may lead to multiple underlying HTTP connection pools beingcreated, potentially resulting in resource exhaustion.
This update does not modify lifecycle behavior or bean creation logic.
It only adds a warning log to improve visibility and prevent accidental misuse.
Additionally, documentation has been updated to clarify that custom
Clientbeans should be singleton-scoped.