ami auto update done

api/services/ocean/aws/responses/amiAutoUpdate.yaml

@@ -1,5 +1,4 @@
 description: EKS AMI Auto Update Response
-# todo shauli - Aggregated Summary Costs? Fixed
 content:
   application/json:
     schema:
@@ -12,7 +11,6 @@ content:
               properties:
                 url:
                   example: "/ocean/aws/eks/cluster/o-abcd1234/amiAutoUpdate"
-                  # todo shauli - aggregatedCosts? Fixed
                 method:
                   example: "POST"
             response:

api/services/ocean/aws/schemas/amiAutoUpdate.yaml

@@ -33,12 +33,18 @@ properties:
         type: integer
         description: Indicates the threshold of minimum healthy instances in single batch. If the amount of healthy instances in single batch is under the threshold, the cluster roll will fail. If exists, the parameter value will be in range of 1-100. In case of null as value, the default value in the backend will be 50%. Value of param should represent the number in percentage (%) of the batch.
         example: 100
-        #todo shauli - if default exist, add default field. fixed
+        minimum: 1
+        maximum: 100
+        default: 50
       comment:
         type: string
         description: >
           Add a brief description for the roll. The comment is limited to 256 chars.
         example: "This is why I rolled my cluster."
-    #todo shauli - what about respectPdb? need to discuss
-    #todo shauli - if possible consider using reference to files under roll folder - let's discuss why that better.
+      respectPdb:
+        type: boolean
+        description: >
+          During the roll, if the parameter is set to true we honor PDB during the instance replacement.
+        example: true
+        default: false
 

api/services/ocean/aws/schemas/amiAutoUpdateData.yaml

@@ -40,4 +40,3 @@ properties:
      example: ami-019e5b81636e5a350
      description: |
        The ID of the new AMI that is being used for the VNG.
-    #todo shauli - what will it show if it's double ami in the vng? or this is not relevant? fixed

api/services/ocean/aws/schemas/amiAutoUpdateSummery.yaml

@@ -14,7 +14,6 @@ properties:
     description: >
       Ami update result.
     enum: [ Success, Failed ]
-    #todo shauli - verify lower-upper casing fixed
   data:
     type: array
     items:
@@ -31,7 +30,6 @@ properties:
     example: 2024-01-02T09:57:09.211Z
     description: |
       The AMI update method was triggered at this time.
-    #todo shauli - not create method? need to discuss
   updatedAt:
     type: string
     readOnly: true

api/services/ocean/aws/schemas/ocean-scheduling.yaml

@@ -27,15 +27,16 @@ properties:
             Required field for taskType "clusterRoll", optional field for taskType "amiAutoUpdate".
         taskType:
           type: string
-          example: clusterRoll / amiAutoUpdate
-          #todo shauli - why both of the enum in the example? there can be only one in a request need to discuss
+          example: clusterRoll
           enum: ["clusterRoll", "amiAutoUpdate"]
           description: >
             The activity that you are scheduling. Valid values: "clusterRoll", "amiAutoUpdate". Required for cluster.scheduling.tasks.
         parameters:
           type: object
+          description: | 
+            This field will be compatible to the task type field. 
+            If taskType is defined as "clusterRoll", use cluster roll object in parameters.
           properties:
-            #todo shauli - clusterRoll tree object appears twice in here - verifying this is intentional need to discuss
             clusterRoll:
               type: object
               properties: