ami auto update

spotinst · Jan 10, 2024 · 56174b3 · 56174b3
1 parent 0ceb5a3
commit 56174b3
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/api/services/ocean/aws/responses/amiAutoUpdate.yaml b/api/services/ocean/aws/responses/amiAutoUpdate.yaml
@@ -1,5 +1,5 @@
-description: Ocean Cluster Aggregated Summary Costs Response
-# todo shauli - Aggregated Summary Costs?
+description: EKS AMI Auto Update Response
+# todo shauli - Aggregated Summary Costs? Fixed
 content:
   application/json:
     schema:
@@ -11,8 +11,8 @@ content:
               type: object
               properties:
                 url:
-                  example: "/ocean/aws/k8s/cluster/o-abcd1234/aggregatedCosts/summary"
-                  # todo shauli - aggregatedCosts?
+                  example: "/ocean/aws/eks/cluster/o-abcd1234/amiAutoUpdate"
+                  # todo shauli - aggregatedCosts? Fixed
                 method:
                   example: "POST"
             response:

diff --git a/api/services/ocean/aws/schemas/amiAutoUpdate.yaml b/api/services/ocean/aws/schemas/amiAutoUpdate.yaml
@@ -33,7 +33,7 @@ properties:
         type: integer
         description: Indicates the threshold of minimum healthy instances in single batch. If the amount of healthy instances in single batch is under the threshold, the cluster roll will fail. If exists, the parameter value will be in range of 1-100. In case of null as value, the default value in the backend will be 50%. Value of param should represent the number in percentage (%) of the batch.
         example: 100
-        #todo shauli - if default exist, add default field.
+        #todo shauli - if default exist, add default field. fixed
       comment:
         type: string
         description: >

diff --git a/api/services/ocean/aws/schemas/amiAutoUpdateData.yaml b/api/services/ocean/aws/schemas/amiAutoUpdateData.yaml
@@ -40,4 +40,4 @@ properties:
      example: ami-019e5b81636e5a350
      description: |
        The ID of the new AMI that is being used for the VNG.
-    #todo shauli - what will it show if it's double ami in the vng? or this is not relevant?
+    #todo shauli - what will it show if it's double ami in the vng? or this is not relevant? fixed
diff --git a/api/services/ocean/aws/schemas/amiAutoUpdateSummery.yaml b/api/services/ocean/aws/schemas/amiAutoUpdateSummery.yaml
@@ -14,7 +14,7 @@ properties:
     description: >
       Ami update result.
     enum: [ Success, Failed ]
-    #todo shauli - verify lower-upper casing
+    #todo shauli - verify lower-upper casing fixed
   data:
     type: array
     items:
@@ -31,7 +31,7 @@ properties:
     example: 2024-01-02T09:57:09.211Z
     description: |
       The AMI update method was triggered at this time.
-    #todo shauli - not create method?
+    #todo shauli - not create method? need to discuss
   updatedAt:
     type: string
     readOnly: true

diff --git a/api/services/ocean/aws/schemas/ocean-scheduling.yaml b/api/services/ocean/aws/schemas/ocean-scheduling.yaml
@@ -28,14 +28,14 @@ properties:
         taskType:
           type: string
           example: clusterRoll / amiAutoUpdate
-          #todo shauli - why both of the enum in the example? there can be only one in a request
+          #todo shauli - why both of the enum in the example? there can be only one in a request need to discuss
           enum: ["clusterRoll", "amiAutoUpdate"]
           description: >
             The activity that you are scheduling. Valid values: "clusterRoll", "amiAutoUpdate". Required for cluster.scheduling.tasks.
         parameters:
           type: object
           properties:
-            #todo shauli - clusterRoll tree object appears twice in here - verifying this is intentional
+            #todo shauli - clusterRoll tree object appears twice in here - verifying this is intentional need to discuss
             clusterRoll:
               type: object
               properties: