[BGD-5797] add bns role to list and patch CR #224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
https://spotinst.atlassian.net/browse/BGD-5797
Description
We want the notebook-service to be able to watch sparkapp CR and add annotations
bigdata.spot.io/kill-requested-at
in them and let spark-watcher kill the app.This will happen at each kernel shutdown handled by bns
Checklist
How to test
helm upgrade bigdata-notebook-service-bdenv-vXX bigdata-notebook-service -n spot-system
Test plan and results
cluster role binding

cluster role

bigdata-notebook-service logs showing kernel restart + annotation update

SparkApp CR with annotations
