Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bgd 5200 non root fluentbit sidecars #210

Merged
merged 7 commits into from
May 30, 2024

Conversation

Z4ck404
Copy link
Collaborator

@Z4ck404 Z4ck404 commented May 24, 2024

  • Use non root container images for telemetry fluent-bit sidecars.
  • Use the version fluent-bit 3.0.5 bitnami non-root images

⚠️ Needs this PR to be merged and released first https://github.com/spotinst/bigdata-infrastructure/pull/479

Jira Ticket

https://spotinst.atlassian.net/browse/BGD-5200

Demo:

After applying the charts (see tests bellow), all components are running with the sidecars as non-root
kubectl get pods -o jsonpath="{range .items[*]}{'\n'}{.metadata.name}:{range .status.containerStatuses[*]}{'\n\t'}{.name}{'\t'}{.image}{'\t'}{.state}{end}{end}" -n spot-system

Screenshot 2024-05-27 at 14 14 04

Tests

Before applying the charts bellow, set the the telemetry to true

  telemetry:
    enabled: true
    fluentbit:
      image:
        repository: public.ecr.aws/ocean-spark/fluent-bit
        tag: 3.0.5

Bigdata-noteboook-service

apply the charts to a running DP: helm upgrade bigdata-notebook-service-bdenv-v67 charts/bigdata-notebook-service -n spot-system --debug

Screenshot 2024-05-27 at 13 44 49

The sidecar is running as non-root (version 3.0.5)

Screenshot 2024-05-27 at 13 45 13

Bigdata-operator

Screenshot 2024-05-27 at 13 38 31

spark-operator

  • apply the charts : helm upgrade spark-operator-bdenv-v67 charts/spark-operator -n spot-system --debug
Screenshot 2024-05-27 at 13 58 20

Bigdata-spark-watcher

  • helm upgrade bigdata-spark-watcher-bdenv-v67 charts/bigdata-spark-watcher -n spot-system
Screenshot 2024-05-27 at 14 09 36

Bigdata-proxy

helm upgrade bigdata-proxy-bdenv-v67 charts/bigdata-proxy -n spot-system

Screenshot 2024-05-27 at 14 05 46

The logs from the sidecar :

Screenshot 2024-05-27 at 14 06 25

The cluster is available ✅ :

Screenshot 2024-05-27 at 14 11 02

Checklist:

  • I have filled relevant self assessment (NodeJS, Frontend, Backend)

  • I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)

  • My code follows the style guidelines of this project

  • I have performed a self-review of my own code

  • I have validated all the requirements in the Jira task were answered

  • I have all neccessary approvals for the design/mini design of this task

  • I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)

@Z4ck404 Z4ck404 requested a review from a team as a code owner May 24, 2024 22:39
@Z4ck404 Z4ck404 force-pushed the BGD-5200-non-root-fluentbit-sidecars branch 2 times, most recently from 385b83b to 3fb95bc Compare May 27, 2024 12:13
@Z4ck404 Z4ck404 force-pushed the BGD-5200-non-root-fluentbit-sidecars branch from 3fb95bc to 12a52dd Compare May 29, 2024 08:54
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to maintain the bigdata-notebook-service-storage-server since we disabled the component since the bdenv-v75?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to.
I just wanted to fix all the charts 😅

@Z4ck404 Z4ck404 force-pushed the BGD-5200-non-root-fluentbit-sidecars branch from 12a52dd to 41323da Compare May 30, 2024 09:08
@Z4ck404 Z4ck404 requested review from ImpSy and alextarasov-spot May 30, 2024 09:09
@Z4ck404 Z4ck404 merged commit 3478765 into main May 30, 2024
1 check passed
@Z4ck404 Z4ck404 deleted the BGD-5200-non-root-fluentbit-sidecars branch May 30, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants