moving things around a bit, adding k8s log collector environment vari…

…able
spotinst · Sep 16, 2024 · c0d5dbd · c0d5dbd
1 parent 6a6dec0
commit c0d5dbd
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 19 deletions.
diff --git a/charts/bigdata-spark-watcher/templates/deployment.yaml b/charts/bigdata-spark-watcher/templates/deployment.yaml
@@ -63,17 +63,18 @@ spec:
           env:
             - name: SPOTINST_BASE_URL
               value: {{ .Values.spotBaseUrl }}
-            {{- if .Values.k8sEventLogCollectorEnabled }}
             - name: APP_SYNC_PERIOD
-              value: {{ .Values.k8SEventLogCollection.appSyncPeriod }}
+              value: {{ .Values.appSyncPeriod }}
             - name: APP_SYNC_KILL_GRACE_PERIOD
-              value: {{ .Values.k8SEventLogCollection.appSyncKillGracePeriod }}
+              value: {{ .Values.appSyncKillGracePeriod }}
             - name: APP_SYNC_GHOST_GRACE_PERIOD
-              value: {{ .Values.k8SEventLogCollection.appSyncKillGhostGracePeriod }}
+              value: {{ .Values.appSyncKillGhostGracePeriod }}
             - name: APP_SYNC_REVERSE_GHOST_GRACE_PERIOD
-              value: {{ .Values.k8SEventLogCollection.appSyncReverseGhostGracePeriod }}
+              value: {{ .Values.appSyncReverseGhostGracePeriod }}
             - name: KUBE_EVENT_LOG_COLLECTION_BUCKET_PREFIX
               value: {{ .Values.k8SEventLogCollection.bucketPrefix }}
+            - name: KUBE_EVENT_LOG_COLLECTION_ENVIRONMENT
+              value: {{ .Values.k8SEventLogCollection.environment }}
             - name: AWS_CREDENTIALS_FILE
               value: /creds/aws
             - name: GCP_CREDENTIALS_FILE
@@ -83,10 +84,9 @@ spec:
             - name: CREDS_REFRESH_INTERVAL
               value: 2m
             - name: SPARK_APP_FAILED_EXECUTOR_LIMIT
-              value: {{ .Values.k8SEventLogCollection.sparkAppFailedExecutorLimit }}
+              value: {{ .Values.sparkAppFailedExecutorLimit | quote }}
             - name: SPARK_APP_TERMINATED_CRITICAL_SIDECAR_GRACE_PERIOD
-              value: {{ .Values.k8SEventLogCollection.sparkAppTerminatedCriticalSidecarGracePeriod }}
-            {{- end }}
+              value: {{ .Values.sparkAppTerminatedCriticalSidecarGracePeriod }}
             - name: HTTP_PROXY
               valueFrom:
                 configMapKeyRef:

diff --git a/charts/bigdata-spark-watcher/values.yaml b/charts/bigdata-spark-watcher/values.yaml
@@ -29,7 +29,19 @@ logLevel: debug
 
 killSyncerEnabled: true
 ghostSyncerEnabled: true
+
+appSyncKillGracePeriod: 5m
+appSyncKillGhostGracePeriod: 5m
+appSyncReverseGhostGracePeriod: 30s
+appSyncPeriod: 5m
+sparkAppFailedExecutorLimit: 200
+sparkAppTerminatedCriticalSidecarGracePeriod: 3m
+
 k8sEventLogCollectorEnabled: true
+k8SEventLogCollection:
+  # enabled: true
+  bucketPrefix: "spot-bigdata-logcollector"
+  environment: ""
 
 serviceAccount:
   create: true
@@ -68,17 +80,6 @@ telemetry:
       repository: public.ecr.aws/ocean-spark/fluent-bit
       tag: 3.0.5
 
-k8SEventLogCollection:
-  # enabled: true
-  appSyncPeriod: 5m
-  appSyncKillGracePeriod: 5m
-  appSyncKillGhostGracePeriod: 5m
-  appSyncReverseGhostGracePeriod: 30s
-  bucketPrefix: "spot-bigdata-logcollector"
-  sparkAppFailedExecutorLimit: '200'
-  sparkAppTerminatedCriticalSidecarGracePeriod: 3m
-
-
 nodeSelector: {}
 
 tolerations: