Replaced spotipy with a non-api library#2626
Replaced spotipy with a non-api library#2626TzurSoffer wants to merge 12 commits intospotDL:masterfrom
Conversation
|
I currently have a hardcoded variable in the Spotify.py file, but this should be a config option. I tried to make it a config option, but I am unfamiliar with this code and couldn't. |
…well as some minor issues in tracks)
|
Hey, is there any progress towards merging this PR? |
|
This branch works on my system |
|
@TzurSoffer Have you seen this? |
|
if you see that error, you didnt install my fork as it does not use api.spotify.com... |
4.4.5 I had too many pre-existing versions hanging around, was pointing back to the previous .local install. After removing everything spotdl related, reinstalled again from the fork, and its processing, without the error so far. Thanks! |
|
Works on my system! Thanks! |
|
works very well,thank you! |
|
I tried it with the "artist" option and it doesn't work, I don't know if I'm doing something wrong or not; I run the command on a linux headless server, I attached the command and the error here: Command: spotdl download artist:X --headless --output {artist}/{album}/{title}.{output-ext} --format m4a |
|
Artists are not yet supported, download a playlist with all his songs instead for now |
|
Thanks, it works pretty well! Just running into a couple errors at the moment (running this on mac):
|
|
@taco-mustard Please provide the commands as well as the output from the terminal so I can fix replicate it |
|
This was the code that led to the AttributeError This was the output Found 121 songs in dl_songs (Playlist)
AttributeError: 'Downloader' object has no attribute 'download_url' ``` |
|
@taco-mustard It possible that youtube is bugged, I dont have time to fix it rn. for now, you can do |
|
changing |
|
It works! |
|
works like a charm! |
|
Thankyouu |
|
someone got error "Could not get session auth tokens"? |
|
thanks bro |
Yeah I keep getting that too |
|
@yonka2019 @CrumplyLime are you trying to use Spotify API with auth tokens? if so, do you have an active Spotify subscription and made sure your "Spotify app" is not disabled? This is due to recent Spotify API changes which also disabled my "app" |
Yeah, I've got everything in order for my auth token except for the subscription, but I thought this new pull request was meant to address the subscription exclusivity and make it so non-premium members can also download songs? I hope I haven't misinterpreted the purpose of this pr |
I think this PR is just a workaround the Spotify API changes by using different package which does not rely on Spotify. Try removing your auth tokens and see if it works. |
Unfortunately I still get the same error message, so I'm just gonna assume for the time being I'll need some valid auth tokens. I'm gonna leave my console output here though, hopefully it might be of use |
Yeah seems like it's still trying to use the Spotify API. |
Yeah, I used the recommended download command, the one you're referencing. And no, I'm running this out of a powershell on my native Win11 machine, no virtual envs |
|
Yeah that could cause the issue. Try creating a venv and installing the PR there. In case you are not familiar with it try creating a folder open terminal in the folder and run python (or python3 or py or full path for the python.exe) -m venv {folder name} then activate the venv |
That was certainly interesting trying this out, never made a virtual env before. But yeah I still have the same error output on my machine; I followed your instructions, then I went ahead and ran spotdl with my playlist in the venv but I still get the |
|
Have you tried deleting your .spotdl folder from the c:/users/YOURACCOUNT/.spotdl? there might be a cache file which is causing this error. Make sure you have enabled "show hidden files" |
|
the error isnt consistent |
Yeah, even with that folder deleted the issue persists for me |
|
What does running |
It should be the latest one at |
|
Then run |
I went ahead and did that, after updating the newest version, but I'm still getting the same error |
|
Thats odd... What command are you using? Also, does running |
Nope that fails also with the same error message, I've been using |
|
I didn't provide a compiled exe... |
This is most likely the issue. You are updating the spotdl package but using old exe binary |
|
Oh, I'm sorry I was accidentally using the .exe binary I saw in one of the directories in the venv. But I tried it regularly as |
|
Ran your you are the man/woman! <3 |
Title
Due to recent changes in Spotify, the api is no longer useful to non-premium users, therfore I have replaced it.
Description
I have made a wrapper to spotAPI, which functions as a drag-n-drop replacement to spotipy, it not perfect, but it has fixed spotdl.
To install working verison run
pip install git+https://github.com/TzurSoffer/spotify-downloaderIf this helped you a star to my fork and bump would be appreciated to help promote this fix.
Related Issue
#2621
#2617
Motivation and Context
It solves the problem of the app not working without Spotify Premium.
How Has This Been Tested?
I have tested both playlists and individual songs.
Types of Changes
Checklist