Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExtensionException in OSGi environment for global extension #2079

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

AndreasTu
Copy link
Member

Implement the same resource logic with ContextClassLoader as JUnit platform.

Fixes #2076

Implement the same resource logic with ContextClassLoader as JUnit platform.

Fixes spockframework#2076
@AndreasTu AndreasTu added this to the 2.4-M6 milestone Jan 8, 2025
@AndreasTu AndreasTu self-assigned this Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.87%. Comparing base (9d1e819) to head (b6e4794).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2079   +/-   ##
=========================================
  Coverage     81.87%   81.87%           
+ Complexity     4687     4686    -1     
=========================================
  Files           452      452           
  Lines         14658    14656    -2     
  Branches       1845     1845           
=========================================
- Hits          12001    12000    -1     
  Misses         1976     1976           
+ Partials        681      680    -1     
Files with missing lines Coverage Δ
...spockframework/runtime/ExtensionClassesLoader.java 68.42% <100.00%> (ø)
...n/java/org/spockframework/util/ReflectionUtil.java 89.82% <100.00%> (+0.47%) ⬆️

@AndreasTu AndreasTu requested a review from leonard84 January 10, 2025 16:30
@leonard84 leonard84 enabled auto-merge (squash) January 12, 2025 15:08
@leonard84 leonard84 merged commit 8017fc3 into spockframework:master Jan 12, 2025
29 checks passed
@AndreasTu AndreasTu deleted the fix_2076 branch January 12, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExtensionException in OSGi environment for global extension
2 participants