For updating docker blog#471
Open
xlabd wants to merge 5 commits intospmallick:masterfrom
xlabd:master
Open
Conversation
Update for docker
asmorkalov
reviewed
Aug 18, 2020
Collaborator
asmorkalov
left a comment
asmorkalov
left a comment
There was a problem hiding this comment.
@xlabd Is it for particular post or you want to bring general purpose image for sample code?
docker-opencv/Dockerfile
Outdated
| && wget https://raw.githubusercontent.com/spmallick/learnopencv/master/docker-opencv/Sample-Code-Cpp-Unix/sampleCode.cpp | ||
|
|
||
| RUN apt-get -qq -y autoremove \ | ||
| && apt-get -qq autoclean |
Collaborator
There was a problem hiding this comment.
It should be done at the end of each RUN command with apt as Docker stores dedicated layer for each RUN.
Contributor
Author
There was a problem hiding this comment.
Thanks for the information!
Contributor
Author
|
This is a general-purpose docker image with Python 3, CPP, and OpenCV 4.4.0 installed. |
Collaborator
|
I added alternative solution several days ago: #453. M.b. we need to align the images or use one for both cases? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@vikasgupta-github