Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to indicate bad record in gRPC responses #59

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

tigrannajaryan
Copy link
Collaborator

Resolves #57

TODO: add tests that verify the bad id reporting.

Resolves #57

TODO: add tests that verify the bad id reporting.
@tigrannajaryan tigrannajaryan requested a review from dmitryax March 28, 2025 17:53
Copy link
Collaborator

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The comment isn't blocking

@tigrannajaryan tigrannajaryan merged commit 20ae670 into main Mar 28, 2025
2 checks passed
@tigrannajaryan tigrannajaryan deleted the tigran/grpcserver branch March 28, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bad record ids to gRPC response
2 participants