Generating enums from IDL #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #51 We now have separate "storage" and "exported" types defined for STEF data types. For most types they are equivalent except for Enums where the "storage" type is uint64, while "exported" type is user defined. The generated code now uses either "storage" or "exported" type, depending on the context and converts between the types as needed. The Metric.Type field now uses enum code generation. Previously manually created enums.go is deleted. enums.go also contains MetricFlags which is not an enum that we want to generate so it was moved to internal/metricflags.go. I will need to refactor internal/metricflags.go, but will do it in a future PR to keep the size of this PR manageable. The generator needs more tests to verify how it works with enums in other data types (oneof,array,multimap). We need to add a better test suite for generator in the future.
dmitryax
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #51
We now have separate "storage" and "exported" types defined for STEF data types. For most types they are equivalent except for Enums where the "storage" type is uint64, while "exported" type is user defined.
The generated code now uses either "storage" or "exported" type, depending on the context and converts between the types as needed.
The Metric.Type field now uses enum code generation. Previously manually created enums.go is deleted. enums.go also contains MetricFlags which is not an enum that we want to generate so it was moved to internal/metricflags.go.
I will need to refactor internal/metricflags.go, but will do it in a future PR to keep the size of this PR manageable.
The generator needs more tests to verify how it works with enums in other data types (oneof,array,multimap). We need to add a better test suite for generator in the future.