Feature/string builder optimise #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before the task-counter is updated (it updates on a background task).
…xpense of slightly slower sends.
jayaraut
reviewed
May 26, 2023
| @@ -1,12 +1,13 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>net45</TargetFrameworks> | |||
| <TargetFrameworks>net452;net6.0</TargetFrameworks> | |||
There was a problem hiding this comment.
Net452 is fine - net 462 project can happily reference the 452 build
jayaraut
suggested changes
May 26, 2023
| serializedEventInfo = SerializeEventInfo(ei); | ||
| } | ||
| else | ||
| if (formatter != null) |
There was a problem hiding this comment.
make it possible for DE and NL locales to get data through this call.
There was a problem hiding this comment.
I can see you have a PR already to do this. This one should stay focused on improving memory usage, and your PR can provide DE / NL locale support.
@jayaraut I don't think there's any need for this PR to address those issues - pls see my comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate approaches for buffering data before sending to Splunk, aiming to avoid Large Object Heap allocations. I've got 3 alternative approaches each which allocates less on the LOH than the original...
Keen for feedback on if we should offer them all / remove some..
Here's some memory profiles
Original
StringBuilder ToString() at time of sending content:
Buffering to file, then using FileContent
Using a PushStreamContent to stream smaller JSON strings at point of HTTP send:
