Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D assistant take 2 #355

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

D assistant take 2 #355

wants to merge 24 commits into from

Conversation

pyth0n1c
Copy link
Contributor

@pyth0n1c pyth0n1c commented Jan 23, 2025 •
edited
Loading

assistant work
This contains a Proof of Concept and initial progress for discussion purposes.
DO NOT MERGE AT THIS TIME

@pyth0n1c pyth0n1c added the Draft label Jan 27, 2025
pyth0n1c added 18 commits January 28, 2025 16:01
@pyth0n1c
Merge branch 'main' into d_assistant_take_2
5258a6a
@pyth0n1c
more progress on
c942cca 
resolving circular
import issues
@pyth0n1c
Huge cleanup around object construction
c5067ee 
in the directory. No need to pass around the type
of an object, we have the Object class!
@pyth0n1c
Merge branch 'main' into d_assistant_take_2
4dc2a01
@pyth0n1c
cleanup director. add containing folder
ebbc02f 
to all SecurityContentObjects to aid
in parsing.
@pyth0n1c
Merge branch 'main' into d_assistant_take_2
5f5f43c
@pyth0n1c
clean up the director a bit
28af8e8
@pyth0n1c
remove duplcate line at
1448eb0 
end of file
@pyth0n1c
A number of improvements and restructuring of
9acf456 
files.
@pyth0n1c
fix deprecation file name
a378482
@pyth0n1c
Merge branch 'main' into d_assistant_take_2
bfdc941
@pyth0n1c
More deprecation progress
c37084c 
to support deprecation of
more than just detection
content. Also, enforce
the presence of deprecation
info in the deprecation_yml
when content is marked as
deprecated.
@pyth0n1c
more deprecation progress
fd86570
@pyth0n1c
Merge branch 'main' into d_assistant_take_2
1565de2
@pyth0n1c
We are now generating a deprecation CSV in
697910e 
dist that looks appropriate. However lots of things
are still a bit sloppy. We will need some comment
on the contents of everything.
@pyth0n1c
More progress on writing deprecation CSV to
68e1d32 
buld directory.
@pyth0n1c
progress on exceptions for content
d488456 
we should have removed but did not
@pyth0n1c
better deprecation failure error strings
12152cd
@patel-bhavin
Copy link
Contributor

Hi Eric, a few comments :

  • Since we are creating this automatically at build time , should we drop this lookup file in dist/ and throw in a stanza in transforms? We can also maintain this in the lookups directory as the website will need this file as well.

  • Lets add the name of the replacement detection name to the CSV (it would better for the dashboard)

pyth0n1c added 3 commits March 17, 2025 16:41
@pyth0n1c
roll back status removed and remove
a70c3e7 
migration_guide from CSV file output
@pyth0n1c
Don't try to populate Investigations
f64095c 
anymore. The folder does not
exist in the repo, and we get
an error if that folder does not
exist.
@pyth0n1c
Many changes to meet new structure/naming
e6bce99 
around deprecated vs removed content.
Improvements to the generation of
the deprecated_csv lookup file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyth0n1c @patel-bhavin