feat: generate another .conf-file when conf parameter is used#1608
feat: generate another .conf-file when conf parameter is used#1608kkedziak-splunk merged 26 commits intodevelopfrom
Conversation
|
Should we create |
|
@hetangmodi-crest |
|
I mean the actual parameters with their description and default values (if provided). Just like we are having |
@kkedziak-splunk you can check one of our TAs to see the example, one of the cloud TAs should be a good candidiate. |
# Conflicts: # splunk_add_on_ucc_framework/generators/conf_files/create_inputs_conf.py
# Conflicts: # splunk_add_on_ucc_framework/generators/conf_files/create_inputs_conf.py
|
@hetangmodi-crest would appreciate your review on this change please :) |
artemrys
changed the title
There was a problem hiding this comment.
For me to understand - we do not have service_with_conf_param in inputs.conf anymore but we did not create a dedicated file for it during the build time.
Did we check that this file will be indeed created when a new input is created?
Can we please also check whether AWS add-on is not impacted because of this change.
There was a problem hiding this comment.
- I was experimenting and decided to revert this part and add entries to
inputs.conffor every input, as this parameterpython.version = python3, although not read by the input, it may be read by Splunk when starting the input. - Yes, the file is created when input is added. I tested it locally.
- AWS shows no changes (used
diff -r dir1 dir2) but it is because it contains those files in thedefaultdirectory. The same is with the GCP TA.
One more thing about conf files not being created - I was experimenting with that and it seems that we could create those files with default values. But on the other hand we haven't done that so far. And I saw that default values are handled by the handlers.
# Conflicts: # splunk_add_on_ucc_framework/generators/conf_files/create_inputs_conf.py # tests/unit/generators/conf_files/test_create_inputs_conf.py
Code Coverage 🎉
|
3 participants
Issue number: ADDON-78536
PR Type
What kind of change does this PR introduce?
Summary
Changes
The "conf" parameter for inputs indicates that a separate config file should be used. Therefore inputs with this parameter should not be included in inputs.conf and inputs.conf.spec.
Also,
disableNewInputsparameter is improved.User experience
No changes.
Checklist
If an item doesn't apply to your changes, leave it unchecked.