Skip to content

Commit 9ea75b2

Browse files
authored
Merge pull request #7 from splitio/add-segment-tags
Added tags property support for segment object.
2 parents a9e7b1b + 433e78d commit 9ea75b2

File tree

3 files changed

+22
-4
lines changed

3 files changed

+22
-4
lines changed

splitapiclient/resources/segment.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,11 @@ class Segment(BaseResource):
1212
'description': 'string',
1313
'trafficType' : {
1414
'id': 'string',
15-
'namr': 'string'
15+
'name': 'string'
1616
},
17-
'workspaceId' : 'string'
17+
'workspaceId' : 'string',
18+
'creationTime' : 'number',
19+
'tags': [{'name': 'string'}]
1820
}
1921

2022
def __init__(self, data=None, client=None):
@@ -27,6 +29,9 @@ def __init__(self, data=None, client=None):
2729
self._description = data.get('description')
2830
self._trafficType = TrafficType(data.get('trafficType')) if 'trafficType' in data else {}
2931
self._workspace_id = data.get('workspaceId')
32+
self._tags = data.get('tags') if 'tags' in data else []
33+
self._creationTime = data.get('creationTime') if 'creationTime' in data else 0
34+
3035

3136
@property
3237
def name(self):

splitapiclient/tests/microclients/segment_microclient_test.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,13 @@ def test_list(self, mocker):
1616
data = {'objects': [{
1717
'name': 'seg1',
1818
'description': 'desc',
19+
'creationTime' : None,
20+
'tags': None
1921
}, {
2022
'name': 'seg1',
2123
'description': 'desc',
24+
'creationTime' : None,
25+
'tags': None
2226
}],
2327
'offset': 1,
2428
'totalCount': 2,
@@ -36,12 +40,16 @@ def test_list(self, mocker):
3640
'name': 'seg1',
3741
'description': 'desc',
3842
'trafficType': None,
39-
'workspaceId': None
43+
'workspaceId': None,
44+
'creationTime' : None,
45+
'tags': None
4046
}, {
4147
'name': 'seg1',
4248
'description': 'desc',
4349
'trafficType': None,
44-
'workspaceId': None
50+
'workspaceId': None,
51+
'creationTime' : None,
52+
'tags': None
4553
}]
4654

4755
assert result[0].to_dict() == data[0]

splitapiclient/tests/resources/test_workspace.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,8 @@ def test_add_segment(self, mocker):
111111
data = {
112112
'name': '1',
113113
'description': 'e1',
114+
'creationTime' : None,
115+
'tags': None
114116
}
115117
http_client_mock = mocker.Mock(spec=BaseHttpClient)
116118
http_client_mock.make_request.return_value = data
@@ -133,6 +135,8 @@ def test_add_segment(self, mocker):
133135
data = {
134136
'name': '1',
135137
'description': 'e1',
138+
'creationTime' : None,
139+
'tags': None
136140
}
137141
data['trafficType'] = None
138142
data['workspaceId'] = None
@@ -198,6 +202,7 @@ def test_add_split(self, mocker):
198202
data['rolloutStatus'] = None
199203
data['rolloutStatusTimestamp'] = None
200204
data['tags'] = None
205+
data['owners'] = None
201206

202207
assert attr.to_dict() == data
203208

0 commit comments

Comments
 (0)