Skip to content

Move everything to grammar package #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

Move everything to grammar package #218

merged 1 commit into from
Jul 29, 2025

Conversation

nmayorsplit
Copy link
Contributor

GO SPLIT COMMONS

What did you accomplish?

  • Move everything to grammar package to remove circular dependency.

How do we test the changes introduced in this PR?

Extra Notes

@sonarqube-pull-requests SonarQube Pull Requests
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 50.0% 50.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@nmayorsplit nmayorsplit marked this pull request as ready for review July 28, 2025 21:38
@nmayorsplit nmayorsplit requested a review from a team as a code owner July 28, 2025 21:38
@nmayorsplit nmayorsplit merged commit 375dbff into rule-based-segment Jul 29, 2025
3 of 4 checks passed
@nmayorsplit nmayorsplit deleted the grammar-package branch July 29, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmelograno mmelograno mmelograno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmayorsplit @mmelograno