fix(x509svid): reject leaf SPIFFE IDs with root path#375
Open
maxlambrecht wants to merge 1 commit intospiffe:mainfrom
Open
fix(x509svid): reject leaf SPIFFE IDs with root path#375maxlambrecht wants to merge 1 commit intospiffe:mainfrom
maxlambrecht wants to merge 1 commit intospiffe:mainfrom
Conversation
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
maxlambrecht
requested review from
amartinezfayo,
azdagron and
evan2645
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates
x509svid.Parseandx509svid.ParseRawto reject leaf certificates whose SPIFFE ID has a root/empty path (for example,spiffe://example.org). This aligns with the SPIFFE X.509-SVID spec (SPIFFE spec Section 3.1 "Leaf Certificates"), which requires that leaf certificate SPIFFE IDs MUST have a non-root path component.