Skip to content

Conversation

@randolf-scholz
Copy link

@randolf-scholz randolf-scholz commented Nov 3, 2025

Fixes #14023

Note: git was telling me that these two files were modified, I'm not sure what's going on:

(sphinx) rscholz@Z890:~/github/CONTRIBUTING/sphinx$ git reset --hard
error: failed to encode 'tests/roots/test-root/wrongenc.inc' from UTF-8 to latin-1
error: failed to encode 'tests/roots/test-warnings/wrongenc.inc' from UTF-8 to latin-1
HEAD is now at e5cf9e0da allow mathjax3_config to point to a JS file
(sphinx) rscholz@Z890:~/github/CONTRIBUTING/sphinx$ git status
On branch mathjax_custom_js
Your branch is up to date with 'origin/mathjax_custom_js'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   tests/roots/test-root/wrongenc.inc
        modified:   tests/roots/test-warnings/wrongenc.inc

@AA-Turner AA-Turner added the extensions:mathematics The `sphinx.ext.imgmath`, `sphinx.ext.jsmath`, or `sphinx.ext.mathjax` extensions label Nov 7, 2025
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good based on a desk review (on mobile)!

I've left a few comments, but all minor.

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extensions:mathematics The `sphinx.ext.imgmath`, `sphinx.ext.jsmath`, or `sphinx.ext.mathjax` extensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MathJax: allow passing custom JS config

2 participants