Remove project extras (optional dependencies)#13445
Merged
AA-Turner merged 6 commits intosphinx-doc:masterfrom Aug 2, 2025
Merged
Remove project extras (optional dependencies)#13445AA-Turner merged 6 commits intosphinx-doc:masterfrom
AA-Turner merged 6 commits intosphinx-doc:masterfrom
Conversation
0fd6179 to
2326375
Compare
Contributor
|
@AA-Turner NB: I think one or two of the GitHub Actions CI workflows still rely on the old-style |
# Conflicts: # pyproject.toml
danieleades
reviewed
Apr 28, 2025
AA-Turner
commented
Aug 2, 2025
Contributor
|
@AA-Turner sphinx-doc-translations has 'docs' in requirements.txt and in .readthedocs.yml. How does this PR affects this scenario? |
Member
Author
|
My earlier testing was that A |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Following #13073, we can now consider removing the project extras (
docs,lint, andtest). These were never intended for external use, but theoretically downstreams could attempt to installsphinx[blah]. As such, I've currently proposed a middle ground of removing all optional dependencies but keeping the extra names themselves. I am open to arguments to just remove them, though, or to wait on removing them.I don't know if this has an impact on redistributors, but I imagine that they will have a larger plan for PEP 735 in the abstract.
References
[dependency-groups]table #13073A