Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render smear as quad #36

Merged
merged 20 commits into from
Dec 3, 2024
Merged

feat: render smear as quad #36

merged 20 commits into from
Dec 3, 2024

Conversation

sphamba
Copy link
Owner

@sphamba sphamba commented Dec 1, 2024

Changes

  • remove draw_line and used functions
  • add draw_quad
  • render smear as quad instead of two linked rectangles

Related GitHub issues and pull requests

@sphamba
Copy link
Owner Author

sphamba commented Dec 1, 2024

@folke Hey! I completely rewrote the way the smear is rendered in order to address other issues. I wonder how it runs for you and if you could do some profiling :)

@folke
Copy link
Contributor

folke commented Dec 2, 2024

Looks great!! And performance fine as well.
I actually released the snacks profiler yesterday, so you can now use it too if you want

@sphamba sphamba added the enhancement New feature or enhancement label Dec 2, 2024
@sphamba sphamba merged commit d431ca8 into main Dec 3, 2024
1 check passed
@sphamba sphamba deleted the feat-quad-smear branch December 3, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support arbitrary cursor width
2 participants