perf: use blend hl groups

[folke]

Use the blend property of hl groups to prevent needing to set winblend on every character draw.

Works with or without legacy symbols.

Builds on the wins PR. Actual changes: 335ae3f

[folke]

rebased on main

[sphamba]

Curiously, this way of blending does not work exactly as expected (with or without legacy symbols). There is a visible difference between regular and inverted symbols.

On main:

On this PR:

[folke]

oh right, probably because it blends to the cursorline color instead of the normal bg color...

[folke]

although, there's no cursorline in your screenshot...

[sphamba]

Yep I thought about it afterwards, so I removed the cursorline bg to be sure, and still have the issue.
In neovim's source code, it seems like the blending of fg and bg colors are done differently, so I don't know if we can elegantly resove this issue

[folke]

can reproduce it now. Will check.
btw, doesn't pretty much every font support those legacy block symbols? Especially Nerd Fonts?

[sphamba]

can reproduce it now. Will check. btw, doesn't pretty much every font support those legacy block symbols? Especially Nerd Fonts?

I tried several ones lately (Fira, Iosekva, VictorMono), and the only one that had them was Cascadia Code NF. And it looks weird with Cascadia Code (the legacy symbols have weird spacing)

What font are you using?

[sphamba]

btw, I use opts = { trailing_stiffness = 0 } to debug now

[folke]

I'm using regular Fira Code, but my terminal uses Nerd Font Symbols as a fallback.

Just to be clear, which of the two is actually correct? Top or bottom? :)

[sphamba]

Ah I don't think I can get fallback fonts on my terminal (windows terminal), so I use nerd font files directly (and they don't have the legacy symbols...).

I'd prefer to have the one without the difference of shade between the upper and lower parts of the smear. See with color_levels = 1, no CursorLine:

main:

pr:

[folke]

ok, should be fixed now!

[rachartier]

Ah I don't think I can get fallback fonts on my terminal (windows terminal), so I use nerd font files directly (and they don't have the legacy symbols...).

Hi, just for your information, you can now have fallback fonts in Windows Terminal (check: pull/16821) You only need to separate different fonts with a comma! Tried on Terminal Windows Version : 1.21.3231.0, Win11