Skip to content

Do not inject components in schemas of response bodies #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −1
Open

Do not inject components in schemas of response bodies #2055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion connexion/operations/openapi.py
View file
Open in desktop
Copy link
Author

@f-atwi f-atwi Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what is the purpose of this line.

As far as I know, a global component is to be injected if there is a reference to it. Why is there an injection of all components to the schema?

Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ def produces(self):
def with_definitions(self, schema: dict):
if self.components:
schema.setdefault("schema", {})
schema["schema"]["components"] = self.components
return schema

def response_schema(self, status_code=None, content_type=None):
Expand Down