Skip to content

Print verbose info during PR validation (target: 'develop' branch) #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bact wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Print verbose info during PR validation (target: 'develop' branch) #963

bact wants to merge 5 commits into from

Conversation

@bact
Copy link
Collaborator

@bact bact commented Jan 23, 2025 •
edited
Loading

  • Show the version of the spec-parser currently working with
  • Add --debug --verbose to spec-parser options to print more information for the PR author to understand why the purposed changes failed the validation (if it failed)

@bact
Print debug information during validation
0069ba2 
Add --debug to spec-parser options
(--debug is supposed to be more verbose than --verbose)

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact added the ci Dev workflow and repo management label Jan 23, 2025
@bact bact requested review from goneall, puerco and zvr January 23, 2025 10:47
@bact bact mentioned this pull request Jan 23, 2025
Merged
@bact
--debug -> --verbose
0c23343 
Signed-off-by: Arthit Suriyawongkul <[email protected]>

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@zvr
Copy link
Member

zvr commented Jan 23, 2025

What is the purpose of the "validation"?
I assume to make sure that the input is "correct" / "valid".

What does this mean?
More specifically:

  • errors should most definitely be flagged
  • what about warnings?

And how is it checked?

  • is only the exit code of the process?
  • or is the generated output / error messages also checked?

@bact bact changed the title Print debug information during PR validation (target: 'develop' branch) Print verbose output during PR validation (target: 'develop' branch) Jan 23, 2025
@bact
Copy link
Collaborator Author

bact commented Jan 23, 2025 •
edited
Loading

If it's valid it's good.

If it's not, having some information to understand why it is the case is good.

@bact bact changed the title Print verbose output during PR validation (target: 'develop' branch) Print verbose info during PR validation (target: 'develop' branch) Jan 23, 2025
@goneall
Copy link
Member

goneall commented Oct 10, 2025

@bact - Can you rebase to trigger the CI? The old CI failed, but it is too stale to see the logs

@zvr - any concerns about merging?

@bact
Copy link
Collaborator Author

bact commented Oct 10, 2025

Thanks. I will rebase / check the parameters again to keep up with latest spec-parser.

@goneall
Copy link
Member

goneall commented Nov 14, 2025

Looks like this is still failing the CI

@bact - can you check?

@kestewart kestewart added this to the 3.1 milestone Nov 14, 2025
@bact
Copy link
Collaborator Author

bact commented Jan 21, 2026

The CI is good now. @goneall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goneall goneall goneall approved these changes

@zvr zvr Awaiting requested review from zvr

@puerco puerco Awaiting requested review from puerco

Assignees

No one assigned

Labels

ci Dev workflow and repo management

Projects

None yet

Milestone

3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@bact @zvr @goneall @kestewart