feat(card): support styles#1294
Merged
MerlinMoos merged 3 commits intospartan-ng:mainfrom Mar 31, 2026
Merged
Conversation
Greptile SummaryThis PR introduces multi-theme style support for the Key changes:
Confidence Score: 5/5Safe to merge; the card renders correctly across all themes and the only finding is a minor class-naming inconsistency that does not affect runtime behaviour. All spartan-card-* semantic classes are properly defined in each of the five theme CSS files. The spartan-card-action marker is the sole inconsistency but layout is fully preserved by kept Tailwind positioning classes. No data-integrity, security, or runtime-breakage risk detected. All remaining findings are P2. libs/helm/card/src/lib/hlm-card-action.ts and its CLI template counterpart — .spartan-card-action is referenced but not defined in any theme CSS file. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph After
A2["HlmCard\nspartan-card + structural TW"]
B2["HlmCardHeader\nspartan-card-header + structural TW"]
C2["HlmCardContent\nspartan-card-content"]
D2["HlmCardFooter\nspartan-card-footer + flex/items"]
E2["HlmCardTitle\nspartan-card-title"]
F2["HlmCardDescription\nspartan-card-description"]
G2["HlmCardAction\nspartan-card-action + layout TW"]
end
subgraph ThemeCSS["Theme CSS Files (5 themes)"]
T1[".spartan-card { @apply ... }"]
T2[".spartan-card-header { @apply ... }"]
T3[".spartan-card-content { @apply ... }"]
T4[".spartan-card-footer { @apply ... }"]
T5[".spartan-card-title { @apply ... }"]
T6[".spartan-card-description { @apply ... }"]
T7["❌ .spartan-card-action (missing)"]
end
A2 --> T1
B2 --> T2
C2 --> T3
D2 --> T4
E2 --> T5
F2 --> T6
G2 -.->|no CSS definition| T7
Reviews (1): Last reviewed commit: "chore: fix lint" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/spartan-ng/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
Primitives
Others
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
Other information