Skip to content

pcUpdates #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
Jul 28, 2025
Merged

pcUpdates #701

merged 42 commits into from
Jul 28, 2025

Conversation

PaulZC
Copy link
Contributor

@PaulZC PaulZC commented Jul 23, 2025 •
edited
Loading

  • Adds RTCM1005/1006 parsing on all correction sources to allow the Base ARP to be logged - resolves Add RTCM ARP Logging on non-ZED logging platforms #256
    • Requires SEMP >= v1.0.4. Workflows have been updated
  • Adds improvements to prevent Occasional crash in ntripClientUpdate #695
    • The root cause of the rare crashes was pushGPGGA calling ntripClient->print during an in-progress ntripClient->read from ntripUpdate.
  • Adds ringBuffer improvements:
    • Prevents rbOffsetArray from being filled with zero-length entries
    • Adds a semaphore to prevent processUart1Message and handleGnssDataTask from accessing the buffer head and tails simultaneously
  • Restructures the SD-present test - to prevent the raw SPI 0xFF transfer test from being used unnecessarily
  • Changes how data is written from the RingBuffer to SD - to prevent the ARP and/or Events from being written out of sequence and introducing errors into otherwise clean log files
  • Changes the way maxLogTime and maxLogLength are used
    • These can now be set to zero to disable the associated logging limit
    • Set maxLogTime to zero to log forever
    • Set maxLogLength to zero to log to one file (until maxLogTime is reached)
    • Avoids the use of endSD when opening a new log file
  • Adds settings.haltOnPanic
  • Adds settings.alignedLogFiles - resolves Flag for clean cyclic logging files #630
  • Adds an additional semaphore to prevent tcpServerClientSendData from gatecrashing tcpServerUpdate
  • Make the whole NTRIP_SERVER_DATA ntripServerArray[] volatile
    • Prevents "NTRIP Server ... breaking connection to ... due to lack of RTCM data"

PaulZC added 29 commits July 15, 2025 17:50
@PaulZC
Add RTCM1005/1006 parsing - resolves #256 - requires SEMP v1.0.4
aaf8511
@PaulZC
Move rtcmParserTable etc. into Tasks.ino. Make table global
2ca5841
@PaulZC
Make rtcmData[] and rtcmCount static
6dd3503
@PaulZC
Better ARP log file debug print
46dbdf7
@PaulZC
Merge branch 'release_candidate' into pcUpdates
2de7f6b
@PaulZC
Add missing menuPeriodicPrint systemPrints
e2df434
@PaulZC
Add FUNCTION_ARPWRITE
a7f048a
@PaulZC
Restructure sdCardPresent
87e6b90 
* On postcard, avoid the SPI 0xFF SD card detect test
    * Begin the GPIO expander before the SD
* Use the semaphore to protect the SPI 0xFF card detect test
@PaulZC
Protect ntripClient = new NetworkClient();
411852a
@PaulZC
Initialize sdCardSemaphore = NULL
52e77de
@PaulZC
Sync log file before printing ARP data
997e405
@PaulZC
Don't record ARP if web server is running
05d3da1
@PaulZC
For SD, write all available data to prevent ARP Write gatecrashing re…
9008125 
…gular logged data
@PaulZC
Update required library versions
3e1a593
@PaulZC
Change default ARP logging interval to 60s
794fe34
@PaulZC
Return default ARP logging interval to 10s
d73180c
@PaulZC
Initialize newARPAvailable
5816dc6
@PaulZC
Fix that typo!
4a2e732
@PaulZC
Add ntripClient timeouts:
248ba03 
* Use `NTRIP_CLIENT_RESPONSE_TIMEOUT` for the initial `connect`
* Use `NTRIP_CLIENT_RECEIVE_DATA_TIMEOUT` for the ongoing connection
@PaulZC
Switch to NetworkClient readBytes
b2c6be3
@PaulZC
Update comment
8207da4
@PaulZC
Correctly handle zero maxLogTime_minutes and maxLogLength_minutes
971899b
@PaulZC
Add comments
51526b7
@PaulZC
Add inMainMenu check for NTRIP GGA printing
8ab22c5
@PaulZC
Logging improvements:
a62eb75 
Avoid endSD when opening a new log file due to logLengthExceeded
Avoid beginLogging if log time is exceeded
@PaulZC
Better use of startLogTime_minutes
f0c8076
@PaulZC
Sanity check
f19cb6e
@PaulZC
Update lastUBXLogSyncTime when writing ARP and Events
82681f7
@PaulZC
Merge branch 'release_candidate' into pcUpdates
02be331
@PaulZC PaulZC requested a review from nseidle July 23, 2025 15:57
PaulZC added 7 commits July 24, 2025 11:47
@PaulZC
Move Event and ARP logging into handleGnssDataTask
e402600 
Improve the SD writing. Correctly report write failures
Add missing USB discardRingBufferBytes
@PaulZC
Merge branch 'release_candidate' into pcUpdates
40a17ac
@PaulZC
Remove redundant RTCM parsing
979309d
@PaulZC
ringBuffer improvements
3af1b8f 
Prevent 'empty' (zero length) messages from filling up rbOffsetArray
Update availableHandlerSpace with a single write
Update dataHead in a single write
Strictly, the ringBuffer should be controlled by a semaphore. updateRingBufferTails especially can caused badness if handleGnssDataTask executes at the same time
@PaulZC
More improvements:
f2efc25 
Add getTimeStamp. Clean up timestamp printing
Add ringBufferSemaphore
@PaulZC
Resolve #695 ???!!!
1171241 
Restructure pushGPGGA. Add reentry protection
Only push GPGGA from ntripClientUpdate, NOT from processUart1Message
Revert to ntripClient->read
Add settings.haltOnPanic
@PaulZC
Keep the ntripClient alive by pushing GPGGA when the menu is open
916a41e
@PaulZC PaulZC mentioned this pull request Jul 26, 2025
Open
This was referenced Jul 27, 2025
Open
Open
@PaulZC PaulZC mentioned this pull request Jul 27, 2025
Open
@nseidle
Copy link
Member

nseidle commented Jul 28, 2025

Amazing work Paul. Thank you!

@nseidle nseidle merged commit c766852 into release_candidate Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nseidle nseidle nseidle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulZC @nseidle