Repository navigation
#921 Docker 이미지 레지스트리를 GHCR으로 이전 - #922
Merged
Merged
Conversation
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates Docker image registry from Amazon ECR to GitHub Container Registry (GHCR) and updates GitHub Actions to use the latest versions of various actions.
- Replaces ECR-based workflows with GHCR-based workflows for both development and production environments
- Updates GitHub Actions to their latest versions (checkout@v4, docker actions@v3-v6)
- Simplifies the build process by using native GitHub Container Registry integration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/push_image_ghcr_dev.yml | New workflow for pushing development images to GHCR on dev branch PR merges |
| .github/workflows/push_image_ghcr.yml | New workflow for pushing production images to GHCR on release publication |
| .github/workflows/push_image_ecr_dev.yml | Removed ECR development workflow |
| .github/workflows/push_image_ecr.yml | Removed ECR production workflow |
Comments suppressed due to low confidence (2)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It closes #921
ECR에서 GHCR로 이전하고, Step에서 사용하는 액션들도 최신 버전으로 업데이트하였습니다. 또한 Docker 캐시를 사용하도록 하여, 빌드 속도의 개선이 예상됩니다.
sparcs-kaist/taxi-back#643 와 함께 머지되어야 합니다.