Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies for mast-aladin-lite and jupytext #87

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomdonaldson
Copy link

@tomdonaldson tomdonaldson commented Mar 4, 2025

Adding mast-aladin-lite

The primary purpose of this PR is to add mast-aladin-lite to the roman-cal environment. mast-aladin-lite is our wrapper around ipyaladin which we will use in the platform for on-the-sky visualization and exploration.

The main mast-aladin-lite pip dependency will be added to the Roman-specific deployments/roman/environments/roman-cal/roman-cal.pip. However ipyaladin relies on anywidget to render itself in Jupyter notebooks, and testing has shown that having anywidget in the roman-cal environment is not sufficient to render the ipyaladin widgets. Instead, the environment running Jupyter must also include anywidget, so that has been included in deployments/common/common-env/jupyter.pip. This seems analogous to the need in there for similar packages like jupyterlab-widgets, widgetsnbextension, ipywidgets, ipydatawidgets and sidecar.

Adding jupytext

Secondarily, I also would like to add jupytext to the base Jupyter environment. This allows Jupyter Lab to recognize MyST-NB format .md (Markdown) files as notebooks.

NumPy, SciPy and NAVO have started using these .md notebooks in their tutorials, so it would be nice if our environment recognized them out of the box on all the ST platforms. The Fornax platform also includes jupytext in its base Jupyter environment.

The jupytext addition could be a separate PR if needed, but since the base Jupyter environment was already being updated, maybe putting it here could lower the testing and review overheads.

Questions

This PR has been marked as Draft pending some of the questions below. Thanks for any answers/thoughts/discussion.

  • I've tested this in a local Docker image. What are the next steps to trying this out on the platform?
  • Are there other review criteria outside this PR for adding dependencies like this?
  • Should this PR include any updates to requirements files, and if so, what is the correct procedure for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant