[Merged by Bors] - Improve test config handling #6699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
requested review from
dshulyak,
poszu,
ivan4th,
jellonek and
kacpersaw
as code owners
fasmat
force-pushed
the
improve-test-config-handling
branch
from
3c0ec83 to
72c7b1f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #6699 +/- ##
=======================================
Coverage 79.8% 79.8%
=======================================
Files 366 366
Lines 49967 50006 +39
=======================================
+ Hits 39887 39925 +38
- Misses 7811 7813 +2
+ Partials 2269 2268 -1 ☔ View full report in Codecov by Sentry. |
poszu
approved these changes
Feb 6, 2025
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
## Motivation Instead of having a dedicated test config just for the `node` package, adjust the default test config so it works for all tests similarly and fewer tests have to set their own values.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
## Motivation Instead of having a dedicated test config just for the `node` package, adjust the default test config so it works for all tests similarly and fewer tests have to set their own values.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
## Motivation Instead of having a dedicated test config just for the `node` package, adjust the default test config so it works for all tests similarly and fewer tests have to set their own values.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
## Motivation Instead of having a dedicated test config just for the `node` package, adjust the default test config so it works for all tests similarly and fewer tests have to set their own values.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
## Motivation Instead of having a dedicated test config just for the `node` package, adjust the default test config so it works for all tests similarly and fewer tests have to set their own values.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
## Motivation Instead of having a dedicated test config just for the `node` package, adjust the default test config so it works for all tests similarly and fewer tests have to set their own values.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
## Motivation Instead of having a dedicated test config just for the `node` package, adjust the default test config so it works for all tests similarly and fewer tests have to set their own values.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Instead of having a dedicated test config just for the
nodepackage, adjust the default test config so it works for all tests similarly and fewer tests have to set their own values.Description
This PR does multiple things:
testing.TBparameter so they aren't accidentally called from within production codeconfig.DefaultTestConfigto include the parameters that were previously used innode.getTestConfigTest Plan
existing tests pass
TODO