Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix encoding of bytes in path params to be hex #6695

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Feb 5, 2025

Fixing invalid encoding of bytes path parameters in the node-service API. Previously they were encoded as comma-separated bytes like:

http://127.0.0.1:36637/proposal/10000/243,161,4,243,36,232,61,219,173,52,174,32,221,0,16,11,108,133,168,113,234,178,43,125,216,175,119,36,118,197,121,23

Now, they are encoded in hex:

http://127.0.0.1:34037/proposal/10000/b09edfc6bebe09f4642b99f4d67ae11d977195b75e9204e27d38318dac08daf

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 64.06250% with 23 lines in your changes missing coverage. Please review.

Project coverage is 77.0%. Comparing base (4e3f10c) to head (285a595).
Report is 2 commits behind head on node-split-poc.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
api/node/models/models.go 42.8% 8 Missing and 4 partials ⚠️
api/node/client/client.go 44.4% 5 Missing ⚠️
api/node/client/client.gen.go 80.0% 3 Missing ⚠️
api/node/server/server.gen.go 80.0% 2 Missing ⚠️
api/node/server/server.go 83.3% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           node-split-poc   #6695     +/-   ##
================================================
- Coverage            77.2%   77.0%   -0.2%     
================================================
  Files                 387     387             
  Lines               53664   53691     +27     
================================================
- Hits                41429   41392     -37     
- Misses               9772    9829     +57     
- Partials             2463    2470      +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu poszu merged commit 4edc82c into node-split-poc Feb 6, 2025
13 of 15 checks passed
@poszu poszu deleted the fix-node-api-path-params-encoding branch February 6, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants