Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TODOs in activation and grpcserver packages #6688

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Feb 4, 2025

Motivation

This updates TODOs in the activation and grpcserver packages.

Description

v1 of the API is about to be deprecated, so we won't address the TODOs listed in the grpcserver package any more but instead will focus on the v2 grpc API.

For TODOs in the activation package I created/updated issues and linked them in the code.

Test Plan

n/a

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Feb 4, 2025
@fasmat fasmat changed the title Update todos Update TODOs in activation and grpcserver packages Feb 4, 2025
@fasmat fasmat changed the base branch from develop to malfeasance-fetcher February 4, 2025 18:16
@fasmat fasmat marked this pull request as draft February 4, 2025 18:16
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@4aa7f1a). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
mesh/mesh.go 0.0% 2 Missing ⚠️
api/grpcserver/v2alpha1/transaction.go 75.0% 1 Missing ⚠️
api/grpcserver/v2beta1/transaction.go 75.0% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             develop   #6688   +/-   ##
=========================================
  Coverage           ?   79.8%           
=========================================
  Files              ?     366           
  Lines              ?   49949           
  Branches           ?       0           
=========================================
  Hits               ?   39900           
  Misses             ?    7788           
  Partials           ?    2261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spacemesh-bors spacemesh-bors bot changed the base branch from malfeasance-fetcher to develop February 4, 2025 19:32
@fasmat fasmat marked this pull request as ready for review February 4, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant