Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Beacon from the hare interface #6681

Merged

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Feb 3, 2025

No description provided.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.1%. Comparing base (6045b8d) to head (39c7048).
Report is 3 commits behind head on node-split-poc.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
node/node.go 0.0% 9 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           node-split-poc   #6681   +/-   ##
==============================================
  Coverage            77.1%   77.1%           
==============================================
  Files                 386     386           
  Lines               53660   53667    +7     
==============================================
+ Hits                41411   41421   +10     
+ Misses               9786    9779    -7     
- Partials             2463    2467    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu poszu force-pushed the node-split-optimize-beacon-queries branch from 4f5f69a to 6045b8d Compare February 3, 2025 14:36
Base automatically changed from node-split-optimize-beacon-queries to node-split-poc February 3, 2025 14:43
@poszu poszu force-pushed the node-split-poc-remove-beacon-from-hare-interface branch from 18df4fe to 39c7048 Compare February 3, 2025 14:46
@poszu poszu merged commit 3068559 into node-split-poc Feb 3, 2025
15 of 16 checks passed
@poszu poszu deleted the node-split-poc-remove-beacon-from-hare-interface branch February 3, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants