Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added versioning to NodeService and SmesherService #6677

Merged
merged 9 commits into from
Feb 3, 2025
Merged

Added versioning to NodeService and SmesherService #6677

merged 9 commits into from
Feb 3, 2025

Conversation

pigmej
Copy link
Member

@pigmej pigmej commented Jan 30, 2025

@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.1%. Comparing base (1659b3b) to head (b07d0b7).
Report is 40 commits behind head on node-split-poc.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
node/node.go 40.0% 3 Missing ⚠️
api/grpcserver/v2beta1/smeshing.go 88.2% 2 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           node-split-poc   #6677    +/-   ##
===============================================
  Coverage            77.1%   77.1%            
===============================================
  Files                 385     387     +2     
  Lines               53568   53691   +123     
===============================================
+ Hits                41309   41427   +118     
- Misses               9789    9795     +6     
+ Partials             2470    2469     -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fasmat
fasmat reviewed Jan 31, 2025
View reviewed changes
Copy link
Member

@fasmat fasmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests to api/grpcserver/v2beta1 for the new endpoints? 🙂

node/node.go Outdated Show resolved Hide resolved
api/grpcserver/v2beta1/smeshing.go Outdated Show resolved Hide resolved
fasmat
fasmat reviewed Feb 3, 2025
View reviewed changes
api/grpcserver/v2beta1/smeshing_test.go Outdated Show resolved Hide resolved
api/grpcserver/smesher_service_test.go Outdated Show resolved Hide resolved
@fasmat fasmat force-pushed the versioning_services branch from 39bfbee to b07d0b7 Compare February 3, 2025 16:08
@pigmej pigmej merged commit e2eec61 into node-split-poc Feb 3, 2025
16 checks passed
@pigmej pigmej deleted the versioning_services branch February 3, 2025 17:52
@pigmej pigmej mentioned this pull request Feb 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasmat fasmat fasmat left review comments

@poszu poszu poszu approved these changes

@dshulyak dshulyak Awaiting requested review from dshulyak dshulyak is a code owner

@ivan4th ivan4th Awaiting requested review from ivan4th ivan4th is a code owner

@jellonek jellonek Awaiting requested review from jellonek jellonek is a code owner

@kacpersaw kacpersaw Awaiting requested review from kacpersaw kacpersaw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pigmej @poszu @fasmat