Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Use VACUUM when migrating from DB versions below 21 #6283

Closed
wants to merge 1 commit into from

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented Aug 22, 2024

Motivation

We need to vacuum the DB after migrations, and with #6085 merged, we need to use VACUUM INTO based migration for recent DB schema updates

Description

Set DatabaseVacuumState to 21 in the mainnet config.

Test Plan

Verifying on a mainnet node

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.9%. Comparing base (9d39d6c) to head (bb42d8a).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6283     +/-   ##
=========================================
- Coverage     81.9%   81.9%   -0.1%     
=========================================
  Files          312     312             
  Lines        34328   34328             
=========================================
- Hits         28147   28145      -2     
- Misses        4391    4395      +4     
+ Partials      1790    1788      -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivan4th
Copy link
Contributor Author

ivan4th commented Aug 22, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 22, 2024
## Motivation

We need to vacuum the DB after migrations, and with #6085 merged, we need to use VACUUM INTO based migration for recent DB schema updates
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Use VACUUM when migrating from DB versions below 21 [Merged by Bors] - Use VACUUM when migrating from DB versions below 21 Aug 22, 2024
@spacemesh-bors spacemesh-bors bot closed this Aug 22, 2024
@spacemesh-bors spacemesh-bors bot deleted the fix/db-vacuum-state-21 branch August 22, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants