Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add write-coalesing to atx handling #6257

Closed
wants to merge 1 commit into from
Closed

Conversation

acud
Copy link
Contributor

@acud acud commented Aug 14, 2024

Motivation

Adds write-coalescing to ATXs written to DB from gossip and sync handlers.
Closes #5557

Description

Supersedes #6239

Test Plan

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 80.41237% with 19 lines in your changes missing coverage. Please review.

Project coverage is 82.0%. Comparing base (16d8ac9) to head (e74d418).
Report is 14 commits behind head on develop.

Files Patch % Lines
activation/atxwriter/atxwriter.go 79.4% 11 Missing and 4 partials ⚠️
node/node.go 33.3% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6257     +/-   ##
=========================================
- Coverage     82.1%   82.0%   -0.1%     
=========================================
  Files          308     308             
  Lines        34123   34184     +61     
=========================================
+ Hits         28026   28060     +34     
- Misses        4321    4343     +22     
- Partials      1776    1781      +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acud acud force-pushed the new-write-coalescer branch from 72bebde to ba91e05 Compare August 15, 2024 14:06
@acud acud force-pushed the new-write-coalescer branch from b910d77 to 422f870 Compare August 28, 2024 19:21
addnew

move to different pkg

wip

wip

add benchmarks

build

lint

wtflint

stupid linter

thx mafa

minor correctness changes

wip

wip

add-more-metrics

wip
@acud acud force-pushed the new-write-coalescer branch from 422f870 to 7e74bdf Compare September 6, 2024 17:55
@acud acud closed this Oct 10, 2024
@fasmat fasmat deleted the new-write-coalescer branch October 17, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk write ATXes to the DB
1 participant