-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Use gotestsum in system tests #6230
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6230 +/- ##
=========================================
- Coverage 82.1% 82.0% -0.1%
=========================================
Files 309 309
Lines 34120 34120
=========================================
- Hits 28015 27999 -16
- Misses 4328 4340 +12
- Partials 1777 1781 +4 ☔ View full report in Codecov by Sentry. |
bors try |
tryBuild failed: |
poszu
approved these changes
Aug 8, 2024
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
## Motivation `gotestsum` can be used to run a compiled test binary and parse its output which would allow us to use it for system tests as well.
Pull request successfully merged into develop. Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
gotestsum
can be used to run a compiled test binary and parse its output which would allow us to use it for system tests as well.Description
Updated the
Dockerfile
andMakefile
of system tests to usegotestsum
as runner for the tests.Test Plan
existing tests pass.
TODO