Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Use gotestsum in system tests #6230

Closed
wants to merge 4 commits into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Aug 8, 2024

Motivation

gotestsum can be used to run a compiled test binary and parse its output which would allow us to use it for system tests as well.

Description

Updated the Dockerfile and Makefile of system tests to use gotestsum as runner for the tests.

Test Plan

existing tests pass.

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.0%. Comparing base (bdb32e2) to head (6583c73).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6230     +/-   ##
=========================================
- Coverage     82.1%   82.0%   -0.1%     
=========================================
  Files          309     309             
  Lines        34120   34120             
=========================================
- Hits         28015   27999     -16     
- Misses        4328    4340     +12     
- Partials      1777    1781      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat
Copy link
Member Author

fasmat commented Aug 8, 2024

bors try

spacemesh-bors bot added a commit that referenced this pull request Aug 8, 2024
@spacemesh-bors
Copy link

spacemesh-bors bot commented Aug 8, 2024

try

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Aug 8, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 8, 2024
## Motivation

`gotestsum` can be used to run a compiled test binary and parse its output which would allow us to use it for system tests as well.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Aug 8, 2024

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Use gotestsum in system tests [Merged by Bors] - Use gotestsum in system tests Aug 8, 2024
@spacemesh-bors spacemesh-bors bot closed this Aug 8, 2024
@spacemesh-bors spacemesh-bors bot deleted the use-gotestsum-systests branch August 8, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants