[Merged by Bors] - test(hare): add cleanup #6227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6227 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 308 309 +1
Lines 33906 34033 +127
=========================================
+ Hits 27829 27925 +96
- Misses 4304 4324 +20
- Partials 1773 1784 +11 ☔ View full report in Codecov by Sentry. |
fasmat
approved these changes
Aug 7, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
## Motivation Adds a missing cleanup to drain goroutines on test completion.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
## Motivation Adds a missing cleanup to drain goroutines on test completion.
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds a missing cleanup to drain goroutines on test completion.
Description
Test Plan
TODO