[Merged by Bors] - Upload go-sm release builds to R2 #6225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andres-spacemesh
requested review from
dshulyak,
fasmat,
poszu,
ivan4th and
acud
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6225 +/- ##
========================================
Coverage 82.0% 82.1%
========================================
Files 308 307 -1
Lines 33913 34105 +192
========================================
+ Hits 27829 28012 +183
- Misses 4311 4317 +6
- Partials 1773 1776 +3 ☔ View full report in Codecov by Sentry. |
fasmat
reviewed
Aug 14, 2024
.github/workflows/release.yml
Outdated
| AWS_ACCESS_KEY_ID: ${{ secrets.CLOUDFLARE_GO_SM_BUILDS_ACCESS_KEY_ID }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.CLOUDFLARE_GO_SM_BUILDS_SECRET_ACCESS_KEY }} | ||
| SOURCE_DIR: build-zip | ||
| DEST_DIR: '${{ github.ref_name }}' |
There was a problem hiding this comment.
NIT: the apostrophes aren't needed 🙂
Suggested change
| DEST_DIR: '${{ github.ref_name }}' | |
| DEST_DIR: ${{ github.ref_name }} |
fasmat
requested changes
Aug 14, 2024
fasmat
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Created a test release to see if the new links work: https://github.com/spacemeshos/go-spacemesh/releases/tag/v1.7.0-citest.0-nomain
seems to be working OK
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
## Motivation Upgrade the release process with R2 uploads to reduce costs and safeguarding against network charges and abuse, while keeping the GCP bucket as a temporary backup. Co-authored-by: Matthias <[email protected]>
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Upgrade the release process with R2 uploads to reduce costs and safeguarding against network charges and abuse, while keeping the GCP bucket as a temporary backup.
Description
Introduces a release upload to R2 while maintaining GCP as a backup. This step is part of a larger migration plan that will eventually see the full transition to R2, including the smapp builds.
Test Plan
Test the upload to the GCS Bucket