[Merged by Bors] - Update gcp auth to Workload Identity #6223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andres-spacemesh
requested review from
dshulyak,
fasmat,
poszu,
ivan4th and
acud
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6223 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 307 307
Lines 34105 34105
=======================================
+ Hits 27997 28000 +3
+ Misses 4331 4328 -3
Partials 1777 1777 ☔ View full report in Codecov by Sentry. |
fasmat
reviewed
Aug 14, 2024
|
bors try |
fasmat
approved these changes
Aug 16, 2024
tryBuild failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
## Motivation Enhance application security by migrating from service account key-based authentication to workload identity. This aligns with best practices for cloud-based applications. [WIF](https://cloud.google.com/iam/docs/workload-identity-federation) Co-authored-by: Matthias <[email protected]>
|
Build failed: |
|
bors merge |
|
Merge conflict. |
fasmat
force-pushed
the
update-gcp-auth-to-wif
branch
from
7fb188b to
ab5c394
Compare
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2024
## Motivation Enhance application security by migrating from service account key-based authentication to workload identity. This aligns with best practices for cloud-based applications. [WIF](https://cloud.google.com/iam/docs/workload-identity-federation) Co-authored-by: Matthias <[email protected]>
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Enhance application security by migrating from service account key-based authentication to workload identity. This aligns with best practices for cloud-based applications. WIF
Description
Previously, the application relied on a service account key for authentication. To address security concerns associated with static credentials, introduce workload identity authentication. This eliminates service account key management and provides finer-grained access control.
Note: This change has been successfully implemented and tested in the
devops-appsrepoTest Plan
Test the upload to the GCS Buckets and Systest execution
TODO