Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - test(hare): add db cleanup #6221

Closed
wants to merge 4 commits into from
Closed

Conversation

acud
Copy link
Contributor

@acud acud commented Aug 6, 2024

Motivation

Adding a cleanup for the in-memory db we are using in hare.

Description

There's too much dangling goroutines when we dump the output of the failing tests on hare due to the cleanup not being called on the inmem sqlite.

Test Plan

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.0%. Comparing base (6b39ce4) to head (8cd6352).
Report is 3 commits behind head on develop.

Files Patch % Lines
sql/database.go 71.4% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6221     +/-   ##
=========================================
- Coverage     82.0%   82.0%   -0.1%     
=========================================
  Files          308     308             
  Lines        33906   33913      +7     
=========================================
- Hits         27829   27828      -1     
- Misses        4304    4311      +7     
- Partials      1773    1774      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sql/database.go Outdated Show resolved Hide resolved
sql/database.go Outdated Show resolved Hide resolved
acud and others added 2 commits August 6, 2024 12:26
Co-authored-by: Matthias Fasching <[email protected]>
Co-authored-by: Matthias Fasching <[email protected]>
@acud
Copy link
Contributor Author

acud commented Aug 6, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 6, 2024
## Motivation

Adding a cleanup for the in-memory db we are using in hare.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Aug 6, 2024

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title test(hare): add db cleanup [Merged by Bors] - test(hare): add db cleanup Aug 6, 2024
@spacemesh-bors spacemesh-bors bot closed this Aug 6, 2024
@spacemesh-bors spacemesh-bors bot deleted the cleanup-db-hare branch August 6, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants